Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to customise icon when there are no bookmarks #6

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Added option to customise icon when there are no bookmarks #6

merged 2 commits into from
Oct 31, 2024

Conversation

redsquirrelstudio
Copy link
Contributor

Installing the package in a base filament app causes an error when the tabler blade icon package is not installed.

This pull request does the following:

  • Sets the default icon when there are no bookmarks to a icon from the heroicon set which comes with filament as standard.
  • Allows the developer to customise the empty icon from the config file.

Many thanks!

@redsquirrelstudio
Added option to customise icon when there are no bookmarks
93cc221 
Set the default icon to a heroicon for consistancy
@atmonshi
Copy link
Member

thank you @redsquirrelstudio for these PRs really appreciate it :)

@redsquirrelstudio
Copy link
Contributor Author

Hi @atmonshi

No worries at all, I have implemented your suggestion in #812b6fb

I've done the same for the other icon being fetched from config to be safe :)

Many thanks!

@atmonshi atmonshi merged commit 8391db0 into lara-zeus:1.x Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmonshi atmonshi atmonshi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsquirrelstudio @atmonshi